mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 69528: Fixed a regression in binding GPU container devices.
Date Fri, 07 Dec 2018 19:41:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69528/
-----------------------------------------------------------

Review request for mesos, Jie Yu and Jiang Yan Xu.


Bugs: MESOS-9319
    https://issues.apache.org/jira/browse/MESOS-9319


Repository: mesos


Description
-------

When we changed container devices to be bind mounts, we added an extra
`/dev` path component to the container moount point. This resulted in
devices being mounted as `/dev/dev/nvidia0`.


Diffs
-----

  src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 14871287db8be96b3bb4d655caf43f92f0dbce13



Diff: https://reviews.apache.org/r/69528/diff/1/


Testing
-------

make check (Fedora 29)

Tested manually on a GPU host.

Before:
```
|-/dev                     tmpfs
| |-/dev/pts               devpts
| |-/dev/shm               tmpfs
| |-/dev/full              /dev/mapper/rootvg-rootlv[/var/run/mesos/containers/28f9b34e-9cd4-4b1a-8bb1-237743e4a483/devices/full]
| |-/dev/null              /dev/mapper/rootvg-rootlv[/var/run/mesos/containers/28f9b34e-9cd4-4b1a-8bb1-237743e4a483/devices/null]
| |-/dev/random            /dev/mapper/rootvg-rootlv[/var/run/mesos/containers/28f9b34e-9cd4-4b1a-8bb1-237743e4a483/devices/random]
| |-/dev/tty               /dev/mapper/rootvg-rootlv[/var/run/mesos/containers/28f9b34e-9cd4-4b1a-8bb1-237743e4a483/devices/tty]
| |-/dev/urandom           /dev/mapper/rootvg-rootlv[/var/run/mesos/containers/28f9b34e-9cd4-4b1a-8bb1-237743e4a483/devices/urandom]
| |-/dev/zero              /dev/mapper/rootvg-rootlv[/var/run/mesos/containers/28f9b34e-9cd4-4b1a-8bb1-237743e4a483/devices/zero]
| |-/dev/fuse              devtmpfs[/fuse]
| |-/dev/dev/nvidia-uvm    /dev/mapper/rootvg-rootlv[/var/run/mesos/containers/28f9b34e-9cd4-4b1a-8bb1-237743e4a483/devices/nvidia-uvm/dev/nvidia-uvm]
| |-/dev/dev/nvidiactl     /dev/mapper/rootvg-rootlv[/var/run/mesos/containers/28f9b34e-9cd4-4b1a-8bb1-237743e4a483/devices/nvidiactl/dev/nvidiactl]
| |-/dev/dev/nvidia1       /dev/mapper/rootvg-rootlv[/var/run/mesos/containers/28f9b34e-9cd4-4b1a-8bb1-237743e4a483/devices/nvidia1/dev/nvidia1]
| `-/dev/dev/nvidia0       /dev/mapper/rootvg-rootlv[/var/run/mesos/containers/28f9b34e-9cd4-4b1a-8bb1-237743e4a483/devices/nvidia0/dev/nvidia0]
```

After:
```
|-/dev                     tmpfs
| |-/dev/pts               devpts
| |-/dev/shm               tmpfs
| |-/dev/full              /dev/mapper/rootvg-rootlv[/var/run/mesos/containers/450a0823-78bf-4556-9221-eb1d569ee097/devices/full]
| |-/dev/null              /dev/mapper/rootvg-rootlv[/var/run/mesos/containers/450a0823-78bf-4556-9221-eb1d569ee097/devices/null]
| |-/dev/random            /dev/mapper/rootvg-rootlv[/var/run/mesos/containers/450a0823-78bf-4556-9221-eb1d569ee097/devices/random]
| |-/dev/tty               /dev/mapper/rootvg-rootlv[/var/run/mesos/containers/450a0823-78bf-4556-9221-eb1d569ee097/devices/tty]
| |-/dev/urandom           /dev/mapper/rootvg-rootlv[/var/run/mesos/containers/450a0823-78bf-4556-9221-eb1d569ee097/devices/urandom]
| |-/dev/zero              /dev/mapper/rootvg-rootlv[/var/run/mesos/containers/450a0823-78bf-4556-9221-eb1d569ee097/devices/zero]
| |-/dev/fuse              devtmpfs[/fuse]
| |-/dev/nvidia-uvm        /dev/mapper/rootvg-rootlv[/var/run/mesos/containers/450a0823-78bf-4556-9221-eb1d569ee097/devices/nvidia-uvm/dev/nvidia-uvm]
| |-/dev/nvidiactl         /dev/mapper/rootvg-rootlv[/var/run/mesos/containers/450a0823-78bf-4556-9221-eb1d569ee097/devices/nvidiactl/dev/nvidiactl]
| |-/dev/nvidia1           /dev/mapper/rootvg-rootlv[/var/run/mesos/containers/450a0823-78bf-4556-9221-eb1d569ee097/devices/nvidia1/dev/nvidia1]
| `-/dev/nvidia0           /dev/mapper/rootvg-rootlv[/var/run/mesos/containers/450a0823-78bf-4556-9221-eb1d569ee097/devices/nvidia0/dev/nvidia0]
```


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message