mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 69514: Added gauge metric for operator event stream subscribers.
Date Thu, 06 Dec 2018 02:21:52 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 5, 2018, 6:21 p.m.)

Review request for mesos, Benno Evers, Benjamin Mahler, Gastón Kleiman, and Greg Mann.


Changed metric to a `PushGauge`.  I chose to use the `operator=` instead of `operator++ /
operator--` because the size is bounded and there would be additional logic if I used the
increment operators.

Bugs: MESOS-9258

Repository: mesos


This metric "master/active_operator_event_stream_subscribers" returns
the total number of subscribers to the master's operator event stream.

Diffs (updated)

  docs/ 00c6ea94bcb73746aef740236632ede123f5b534 
  docs/ 6edf361047ee5915514da892c6d885b74a510a72 
  src/master/master.cpp 3b3824a67f46866cd64e32d7f9f92484b5891aa2 
  src/master/metrics.hpp f6bb89da9394bfe469bc690ff2de66824e994098 
  src/master/metrics.cpp f69ed52c1c89912e7a5d26cb9409f5959b09111a 
  src/tests/api_tests.cpp edde48a4b4b46c9f47bc44de389c97b77322b8e8 
  src/tests/master_tests.cpp ef2c00101fc3d30c564a9ca34884dece2cdd2651 




make check

src/mesos-tests --gtest_filter="*MaxEventStreamSubscribers*" --gtest_repeat=-1 --gtest_break_on_failure


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message