mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69163: Set agent and/or resource provider ID in operation status updates.
Date Fri, 30 Nov 2018 11:07:00 GMT


> On Nov. 30, 2018, 3:14 a.m., Greg Mann wrote:
> > src/master/master.cpp
> > Lines 2254-2255 (patched)
> > <https://reviews.apache.org/r/69163/diff/4/?file=2110688#file2110688line2254>
> >
> >     It would make sense to me that we set these IDs if/when they are available.
Currently I don't think it matters since the updates sent here do not need to be acknowledged;
perhaps mention that in the comment?

I added a `TODO` to that effect. The issue currently is that we use `drop` to reject both
"invalid" (e.g., invalid offer or resources) and "valid" operations (rejected because e.g.,
not authorized). For the latter we could set IDs in the terminal status.


> On Nov. 30, 2018, 3:14 a.m., Greg Mann wrote:
> > src/slave/slave.cpp
> > Line 4354 (original), 4353-4359 (patched)
> > <https://reviews.apache.org/r/69163/diff/4/?file=2110691#file2110691line4354>
> >
> >     Why no RP ID? Here and below.

Good catch, fixed two more instances (third wasn't on RP resources).


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69163/#review210962
-----------------------------------------------------------


On Nov. 30, 2018, 12:06 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69163/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2018, 12:06 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gastón Kleiman, and James DeFelice.
> 
> 
> Bugs: MESOS-9293
>     https://issues.apache.org/jira/browse/MESOS-9293
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch sets agent and/or resource provider ID operation status
> update messages. This is not always possible, e.g., some operations
> might fail validation so that no corresponding IDs can be extracted.
> 
> Since operations failing validation are currently directly rejected by
> the master without going through a status update manager, they are not
> retried either. If a master status update manager for operations is
> introduced at a later point it should be possible to forward
> acknowledgements for updates to the master's update manager (not agent
> ID, not resource provider ID).
> 
> 
> Diffs
> -----
> 
>   src/common/protobuf_utils.hpp 1662125ed3e47b179ee32d08c1d3af75553066ba 
>   src/common/protobuf_utils.cpp a45607eed4c4bae5010bcc3f3ffeabd6d911062a 
>   src/master/master.cpp 3b3824a67f46866cd64e32d7f9f92484b5891aa2 
>   src/resource_provider/manager.cpp 6c81c430e9e1205d71982a7fa2bcd9aa15fc01b2 
>   src/resource_provider/storage/provider.cpp a22c82c442304979fbdec0fcb74543077751a135

>   src/slave/slave.cpp 858b78620e1ef33f3587d0bd95a684917aaf5bbb 
>   src/tests/master_tests.cpp ef2c00101fc3d30c564a9ca34884dece2cdd2651 
>   src/tests/mesos.hpp c08e7e6c1dbc3dd9eb980868e43368c0a423c3ee 
> 
> 
> Diff: https://reviews.apache.org/r/69163/diff/5/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message