mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69452: Added a test for executors sending messages to recovered frameworks.
Date Wed, 28 Nov 2018 22:20:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69452/
-----------------------------------------------------------

(Updated Nov. 28, 2018, 10:20 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, and Till Toenshoff.


Changes
-------

Fixed a flake related to `shutdown` not being called.


Bugs: MESOS-9419
    https://issues.apache.org/jira/browse/MESOS-9419


Repository: mesos


Description
-------

This patch adds the `ExecutorMessageToRecoveredHttpFramework` test to
ensure that a master will not crash when forwarding an executor message
to a recovered framework to prevent any future regression of MESOS-9419.


Diffs (updated)
-----

  src/tests/master_tests.cpp 651bb9ba9298fc3d7179ed86487aa55be519ce12 


Diff: https://reviews.apache.org/r/69452/diff/5/

Changes: https://reviews.apache.org/r/69452/diff/4-5/


Testing
-------

make check

This test will fail without r/69451.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message