mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 69454: Added the autoconf `tar-pax` option.
Date Tue, 27 Nov 2018 08:12:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69454/#review210886
-----------------------------------------------------------



PASS: Mesos patch 69454 was successfully built and tested.

Reviews applied: `['69454']`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2653/mesos-review-69454

- Mesos Reviewbot Windows


On Nov. 27, 2018, 5:51 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69454/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2018, 5:51 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The default tar format used in `make dist` is v7, which only supports
> paths of up to 99 bytes in length. This causes errors when building
> the CentOS RPM and adding files from 3rd party packages.
> 
> 
> Diffs
> -----
> 
>   configure.ac c193adf93531170fb31a31c296e3d4ae1d0300b2 
> 
> 
> Diff: https://reviews.apache.org/r/69454/diff/1/
> 
> 
> Testing
> -------
> 
> Ran `support/packaging/centos/build-rpm-docker.sh` and observed no tar errors.
> 
> Without this change, this is what happens:
> ```
> smelt:centos jpeach$ ./build-rpm-docker.sh
> ...
> tardir=mesos-1.8.0 && ${TAR-tar} chof - "$tardir" | GZIP=--best gzip -c >mesos-1.8.0.tar.gz
> tar: mesos-1.8.0/3rdparty/libprocess/3rdparty/glog-0.3.3/vsprojects/logging_unittest/logging_unittest.vcproj:
file name is too long (max 99); not dumped
> tar: mesos-1.8.0/3rdparty/libprocess/3rdparty/glog-0.3.3/vsprojects/logging_unittest_static/logging_unittest_static.vcproj:
file name is too long (max 99); not dumped
> ...
> ```
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message