mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69400: Refactored the test CSI plugin.
Date Mon, 26 Nov 2018 08:28:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69400/
-----------------------------------------------------------

(Updated Nov. 26, 2018, 8:28 a.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
-------

Addressed Benjamin's comments.


Bugs: MESOS-9275
    https://issues.apache.org/jira/browse/MESOS-9275


Repository: mesos


Description
-------

This patch does not introduce any functional change to the test CSI
plugin. It simply refactored the check for the default mount volume
capability and the parsing of `--volumes` flag.


Diffs (updated)
-----

  src/examples/test_csi_plugin.cpp 66f4ee0e2381e94bf9110d1e6e9f79eac939f683 


Diff: https://reviews.apache.org/r/69400/diff/2/

Changes: https://reviews.apache.org/r/69400/diff/1-2/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message