mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 69438: Skipped an rlimit test if the environment is incompatible.
Date Sat, 24 Nov 2018 00:01:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69438/#review210835
-----------------------------------------------------------


Ship it!





src/tests/containerizer/posix_rlimits_isolator_tests.cpp
Lines 138-142 (patched)
<https://reviews.apache.org/r/69438/#comment295595>

    Thanks, that will help others to understand the failure before going through debug-hell
:)


- Till Toenshoff


On Nov. 23, 2018, 11 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69438/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2018, 11 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9397
>     https://issues.apache.org/jira/browse/MESOS-9397
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Skipped an rlimit test if the environment is incompatible.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/posix_rlimits_isolator_tests.cpp 3af00446255a3f5480834db67aa6d4c428526ac3

> 
> 
> Diff: https://reviews.apache.org/r/69438/diff/3/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message