mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69365: Recovered disk through `CREATE_DISK` in test `AgentRegisteredWithNewId`.
Date Tue, 20 Nov 2018 16:21:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69365/#review210710
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/storage_local_resource_provider_tests.cpp
Lines 275-276 (original), 278-279 (patched)
<https://reviews.apache.org/r/69365/#comment295445>

    ```
    // Create a JSON string representing disk profile mappings containing
    // the given profile-parameter pairs.


- Benjamin Bannier


On Nov. 16, 2018, 1:50 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69365/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2018, 1:50 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-9275
>     https://issues.apache.org/jira/browse/MESOS-9275
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Test `AgentRegisteredWithNewId` is now improved to exercise the code
> path for recovering disks created by the last agent through
> `CREATE_DISK`.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp 077a46585bd56181ba199dc529e09f38f4971338

> 
> 
> Diff: https://reviews.apache.org/r/69365/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> This test passes iff r/69362 is applied.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message