mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 69384: Introduced common/authorization and refactored collectAuthorizations.
Date Tue, 20 Nov 2018 02:26:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69384/
-----------------------------------------------------------

(Updated Nov. 20, 2018, 2:26 a.m.)


Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Benjamin Bannier.


Changes
-------

Addressed comment.


Bugs: MESOS-9317
    https://issues.apache.org/jira/browse/MESOS-9317


Repository: mesos


Description
-------

Adds a new collection of authorization specific helper/s to reduce code
duplication and increase efficient test coverage.

Moves the newly introduced 'collectAuthorizations' helper into this new
authorization source unit.


Diffs (updated)
-----

  src/CMakeLists.txt 732368293049b7d9d6f62057344d433637ad44e8 
  src/Makefile.am 2d9c81b149a5764dc82593bef102f5568847daa2 
  src/common/authorization.hpp PRE-CREATION 
  src/common/authorization.cpp PRE-CREATION 
  src/master/master.hpp e77babf22126838c63cd05e483875c9beb3ac5ff 
  src/master/master.cpp 9458ff10999d48e40a8596ec4edf1243591bc0d4 
  src/master/weights_handler.cpp 222ec754e216da195250d1895a728294a076ee5d 
  src/tests/master_tests.cpp ac6bf379c5906cf9612284911c121c9457f648a0 


Diff: https://reviews.apache.org/r/69384/diff/2/

Changes: https://reviews.apache.org/r/69384/diff/1-2/


Testing
-------

make check and private ci


Thanks,

Till Toenshoff


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message