mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69364: Added the `--create_parameters` flag to the test CSI plugin.
Date Mon, 19 Nov 2018 23:35:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69364/
-----------------------------------------------------------

(Updated Nov. 19, 2018, 11:35 p.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
-------

Refactored the patch into r/69400, r/69402 and this one, as suggested by Benjamin.


Bugs: MESOS-9275
    https://issues.apache.org/jira/browse/MESOS-9275


Repository: mesos


Description (updated)
-------

When the flag is specified, `CreateVolume` and `GetCapacity` work only
if the `parameters` argument matches this flag. This will be used to
test the checkpointing of create parameters of CSI volumes in SLRP.


Diffs (updated)
-----

  src/examples/test_csi_plugin.cpp 66f4ee0e2381e94bf9110d1e6e9f79eac939f683 


Diff: https://reviews.apache.org/r/69364/diff/2/

Changes: https://reviews.apache.org/r/69364/diff/1-2/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message