mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69364: Added the `--create_parameters` flag to the test CSI plugin.
Date Mon, 19 Nov 2018 21:58:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69364/#review210610
-----------------------------------------------------------



This patch seems to contain at the same time 1) addition of the new flag, 2) new capability
handling, and 3) fix for the bug mentioned in the commit message. Could you break it apart?

- Benjamin Bannier


On Nov. 16, 2018, 1:48 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69364/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2018, 1:48 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-9275
>     https://issues.apache.org/jira/browse/MESOS-9275
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When the flag is specified, `CreateVolume` and `GetCapacity` work only
> if the `parameters` argument matches this flag. This will be used to
> test the checkpointing of create parameters of CSI volumes in SLRP.
> 
> The patch also fixes the bug that the `CreateVolume` call is not
> idempotent.
> 
> 
> Diffs
> -----
> 
>   src/examples/test_csi_plugin.cpp 66f4ee0e2381e94bf9110d1e6e9f79eac939f683 
> 
> 
> Diff: https://reviews.apache.org/r/69364/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message