mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69362: Checkpointed creation parameters for CSI volumes.
Date Mon, 19 Nov 2018 21:58:07 GMT


> On Nov. 19, 2018, 9:48 p.m., Benjamin Bannier wrote:
> > This patch fails to compile without r/69363, could you move the needed changes from
there into this patch?

Just reordered. Is that okay?


> On Nov. 19, 2018, 9:48 p.m., Benjamin Bannier wrote:
> > src/csi/state.proto
> > Lines 46 (patched)
> > <https://reviews.apache.org/r/69362/diff/1/?file=2108413#file2108413line46>
> >
> >     Let's describe the semantics around empty vs.  populated `parameters` maps instead
of introducing `OPTIONAL` here (which doesn't fit and is confusing).

This is a proto3 message, where there's no distinguish between empty and optional fields.
I'm following the same principle used in CSI: https://github.com/container-storage-interface/spec/blob/master/spec.md#required-vs-optional


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69362/#review210600
-----------------------------------------------------------


On Nov. 19, 2018, 9:29 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69362/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2018, 9:29 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-9275
>     https://issues.apache.org/jira/browse/MESOS-9275
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The parameters of CSI volumes created by SLRPs are now checkpointed, and
> used to validate volumes created from previous SLRP runs.
> 
> 
> Diffs
> -----
> 
>   src/csi/state.proto 8445399ac17cfef740c2523172b34fd5439f2d3a 
>   src/resource_provider/storage/provider.cpp c137fa4f13edc58d93c03a9dd32fdf9d38b38316

> 
> 
> Diff: https://reviews.apache.org/r/69362/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message