mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69366: Used `OperationID` instead of `string` in test helpers.
Date Mon, 19 Nov 2018 21:51:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69366/
-----------------------------------------------------------

(Updated Nov. 19, 2018, 9:51 p.m.)


Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Greg Mann.


Changes
-------

Addressed Benjamin's comments.


Repository: mesos


Description (updated)
-------

This change makes the helper more consisent with other helpers, and is
more future-proof to changes in `OperationID`.


Diffs (updated)
-----

  src/tests/master_slave_reconciliation_tests.cpp 064b4d47598b1d0e18d7bef14ac62d7e5f2c1102

  src/tests/master_tests.cpp ac6bf379c5906cf9612284911c121c9457f648a0 
  src/tests/mesos.hpp 576f4bde88c069ee2fa0dd33912a034437338e7e 
  src/tests/operation_reconciliation_tests.cpp 37d38b3df8c162bd1baa5ce557e54baa5c23a006 
  src/tests/storage_local_resource_provider_tests.cpp 077a46585bd56181ba199dc529e09f38f4971338



Diff: https://reviews.apache.org/r/69366/diff/2/

Changes: https://reviews.apache.org/r/69366/diff/1-2/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message