mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff via Review Board <nore...@reviews.apache.org>
Subject Review Request 69385: Refactored createSubject and authorizeLogAccess to common/authorization.
Date Sun, 18 Nov 2018 23:10:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69385/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Alexander Rojas, Benjamin Bannier, and Greg
Mann.


Repository: mesos


Description
-------

Moves 'createSubject' out of common/http into common/authorization.

Removes duplicate 'authorizeLogAccess' out of master.cpp and slave.cpp.
Introduces 'authorizeLogAccess' within common/authorization.


Diffs
-----

  src/common/authorization.hpp PRE-CREATION 
  src/common/authorization.cpp PRE-CREATION 
  src/common/http.hpp 6ca54a641d1ea1625c70518f8870516664741e9a 
  src/common/http.cpp eeeed9703f80880850b8a1ec9ddd2b1e8f125f36 
  src/master/http.cpp 75ab6ea422a77e25049cd6afe007507d11650a06 
  src/master/master.hpp e77babf22126838c63cd05e483875c9beb3ac5ff 
  src/master/master.cpp 9458ff10999d48e40a8596ec4edf1243591bc0d4 
  src/master/quota_handler.cpp a4975fd50a2be20f3af8bbcfa81255b5dcc64fed 
  src/slave/http.cpp 816aed1607bb7d25851052662b6ffa306c62b983 
  src/slave/slave.hpp 0bd340176e2a8cefdfa7ef71e059441fb171aff6 
  src/slave/slave.cpp 74f6fb9036a9ac4f587f53ec2df04eeb4c167bfb 


Diff: https://reviews.apache.org/r/69385/diff/1/


Testing
-------

`make check` and internal CI validation


Thanks,

Till Toenshoff


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message