mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.
Date Tue, 30 Oct 2018 20:38:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69140/#review210187
-----------------------------------------------------------


Ship it!




Ship It!

- Joseph Wu


On Oct. 30, 2018, 1:20 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69140/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2018, 1:20 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, James Peach, and Joseph
Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allowed for unbundled libarchive on cmake builds.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 9584f537cc2a862ce17037224fd0628ffda54b2b 
>   3rdparty/cmake/FindLIBARCHIVE.cmake PRE-CREATION 
>   cmake/CompilationConfigure.cmake 5d2be0adc55ac5302c2e0e62131feb65657466be 
> 
> 
> Diff: https://reviews.apache.org/r/69140/diff/2/
> 
> 
> Testing
> -------
> 
> cmake .. -DUNBUNDLED_LIBARCHIVE=ON
> cmake .. -DUNBUNDLED_LIBARCHIVE=OFF
> cmake .. -DUNBUNDLED_LIBARCHIVE=ON -DLIBARCHIVE_ROOT_DIR=/usr/local/opt/libarchive
> cmake ..
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message