mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 69214: Mounted devpts with `gid=5` by default.
Date Tue, 30 Oct 2018 18:39:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69214/
-----------------------------------------------------------

(Updated Oct. 30, 2018, 6:39 p.m.)


Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Jiang Yan Xu.


Bugs: MESOS-8547
    https://issues.apache.org/jira/browse/MESOS-8547


Repository: mesos


Description
-------

Some versions of glibc (e.g. 2.17 from CentOS 7) are hard-coded
to expect that terminal devices are owned by the tty group. This
causes containers that allocate TTYs to expect to have to chown
the TTY (see grantpt code in glibc), but it may not be possible
to launch a privileged helper to perform the chown (e.g. because
capabilities have been dropped).

Mounting devpts with `gid=5` is the default in CentOS, Docker,
Fedora and Ubuntu, so this should not cause any compatibility
problems.


Diffs (updated)
-----

  src/linux/fs.cpp 3a58bf9a44c4e1d454f3d754952705b1fd0a0b1d 


Diff: https://reviews.apache.org/r/69214/diff/2/

Changes: https://reviews.apache.org/r/69214/diff/1-2/


Testing
-------

sudo make check (Fedora 28)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message