mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Review Request 69208: Updated new CLI task attach/exec exit strategy.
Date Tue, 30 Oct 2018 00:55:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69208/
-----------------------------------------------------------

Review request for mesos and Kevin Klues.


Bugs: MESOS-9363
    https://issues.apache.org/jira/browse/MESOS-9363


Repository: mesos


Description
-------

Updated new CLI task attach/exec exit strategy.


Diffs
-----

  src/python/cli_new/lib/cli/mesos.py 4a5777bf712c3e5fd20a2bfd6da8fb9f3975d120 
  src/python/cli_new/lib/cli/plugins/task/main.py 5866a23aa0c0dfe141fd8fbe4c9ccd04a2c13a08

  src/python/cli_new/lib/cli/tests/task.py 4b03cf13185f1c718f24a990a75a4dd74e7e132a 


Diff: https://reviews.apache.org/r/69208/diff/1/


Testing
-------

```
(mesos-cli) ?  cli_new (exec-attach) ? mesos-cli-tests
Running the Mesos CLI unit tests

TestAgentPlugin
test_list (cli.tests.agent.TestAgentPlugin) ... ok

TestInfrastructure
test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok

TestTaskPlugin
test_exec (cli.tests.task.TestTaskPlugin) ... ok
test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
test_list (cli.tests.task.TestTaskPlugin) ... ok

----------------------------------------------------------------------
Ran 7 tests in 17.146s

OK
```


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message