mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 69171: Added validation of cache files to the URI Fetcher.
Date Mon, 29 Oct 2018 22:33:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69171/
-----------------------------------------------------------

(Updated Oct. 29, 2018, 10:33 p.m.)


Review request for mesos, Gilbert Song, James Peach, and Joseph Wu.


Bugs: MESOS-7474
    https://issues.apache.org/jira/browse/MESOS-7474


Repository: mesos


Description
-------

Previously, missing cache files could lead to task launch failures.
This patch introduces validation of cache files which happens each
time a downloaded cache entry is requested via the `get()` method.
If validation fails, `get()` returns `None()`, so that the fetcher
retries downloading URI. Currently, we only check the existence of
the cache file during validation.


Diffs (updated)
-----

  src/slave/containerizer/fetcher.cpp e848c86261b75e5549e80276541e5932162fc012 
  src/slave/containerizer/fetcher_process.hpp 56ed6e5455b7d23b4ce84873fe6734b4213df691 


Diff: https://reviews.apache.org/r/69171/diff/2/

Changes: https://reviews.apache.org/r/69171/diff/1-2/


Testing
-------

1. sudo make check (Fedora 25)
2. internal CI


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message