mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.
Date Mon, 29 Oct 2018 20:18:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69146/#review210143
-----------------------------------------------------------


Ship it!




Ship It!

- Joseph Wu


On Oct. 25, 2018, 12:34 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69146/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2018, 12:34 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gilbert Song, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fetcher tests currently rely on some hard-coded paths,
> for example, `/tmp/mesos/fetcher` and `/tmp/frameworks`.
> Thus fetcher tests could fail if these directories already
> exit. This patch makes `FetcherTest` a subclass of
> `MesosTest` which has a `createSlaveFlags()` helper to
> utilize the test sandboxes for related directories to
> avoid interference. The above paths will be
> replaced by `fetch/` and `frameworks/` under the sandbox.
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_tests.cpp 283238cdda17a94e034baa195bd9d4b57e363b8a 
>   src/tests/mesos.cpp c0ab2f7d86c4059f08e730d29456e6cc84c85995 
> 
> 
> Diff: https://reviews.apache.org/r/69146/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message