mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 69180: Enabled streaming requests on the master /api/v1 endpoint.
Date Fri, 26 Oct 2018 18:29:14 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 26, 2018, 11:29 a.m.)

Review request for mesos, Gastón Kleiman and Greg Mann.


Rebased on top of
which introduced a variable inside `master.cpp` with the same name as the one I added in this

Bugs: MESOS-9258

Repository: mesos


This change allows clients of the /api/v1 to specify the HTTP header
'Content-Type: application/recordio' to the master's /api/v1 endpoint.
For now, the only master API that will support streaming requests
is the SUBSCRIBE call.  Other APIs will disallow streaming.

This change makes the `Master::Http::api()` function closely resemble
the `Slave::Http::api()` function.  The main difference is that the
incoming stream reader is stored as a shared_ptr rather than a
Owned object, which to prevent the stream reader from going out of
scope while being passed around via lambda captures.

Diffs (updated)

  src/master/http.cpp 75ab6ea422a77e25049cd6afe007507d11650a06 
  src/master/master.hpp e77babf22126838c63cd05e483875c9beb3ac5ff 
  src/master/master.cpp 704dfc022ea79118ccd93cf59aac20c3ad45f7f9 





See later in chain.


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message