mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 69159: Used an alias for reoccuring complicated type.
Date Fri, 26 Oct 2018 11:48:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69159/#review210089
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/mesos.hpp
Lines 2921-2930 (original), 2911-2920 (patched)
<https://reviews.apache.org/r/69159/#comment294728>

    Indent with 4 spaces.


- Jan Schlicht


On Oct. 25, 2018, 12:54 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69159/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2018, 12:54 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used an alias for reoccuring complicated type.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp 40c63b0d6b272c4fb42ec2a126c1bcacb7abee57 
> 
> 
> Diff: https://reviews.apache.org/r/69159/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message