mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 69185: Added streaming header support for /api/v1 SUBSCRIBE.
Date Fri, 26 Oct 2018 00:56:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69185/
-----------------------------------------------------------

Review request for mesos, Gastón Kleiman and Greg Mann.


Bugs: MESOS-7974 and MESOS-9258
    https://issues.apache.org/jira/browse/MESOS-7974
    https://issues.apache.org/jira/browse/MESOS-9258


Repository: mesos


Description
-------

The existing API allowed the client to send 'Accept' and 'Content-Type'
headers of 'application/json' or 'application/protobuf'.

The SUBSCRIBE endpoint would also take a 'Content-Type' of those two
types, but always return content with 'application/recordio' (because
this is a streaming response).  This maintains that behavior while
also allowing the user to use streaming headers correctly.


Diffs
-----

  src/master/http.cpp 75ab6ea422a77e25049cd6afe007507d11650a06 
  src/master/master.hpp ea7e9242b62fe6c2cc0e717f9a9f2f0c1cc0a390 


Diff: https://reviews.apache.org/r/69185/diff/1/


Testing
-------

make

See later in chain.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message