mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 69184: Marked internal::recordio::Reader as non-copyable/assignable.
Date Fri, 26 Oct 2018 00:56:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69184/
-----------------------------------------------------------

Review request for mesos, Gastón Kleiman and Greg Mann.


Bugs: MESOS-9258
    https://issues.apache.org/jira/browse/MESOS-9258


Repository: mesos


Description
-------

This helper object is basically a wrapper around a libprocess actor.
In the current implementation, if the helper is destructed, the
underlying libprocess actor will be terminated as well.  This means
an errorneous copy of this helper object may result in a dead PID,
which is unguarded and may result in CHECK failures in some scenarios.


Diffs
-----

  src/common/recordio.hpp 8cb2e73f16c753a85074fbf2ae9fd92ae0d2aeea 


Diff: https://reviews.apache.org/r/69184/diff/1/


Testing
-------

make

See later in chain.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message