mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Review Request 69180: Enabled streaming requests on the master /api/v1 endpoint.
Date Fri, 26 Oct 2018 00:51:34 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Gastón Kleiman and Greg Mann.

Bugs: MESOS-9258

Repository: mesos


This change allows clients of the /api/v1 to specify the HTTP header
'Content-Type: application/recordio' to the master's /api/v1 endpoint.
For now, the only master API that will support streaming requests
is the SUBSCRIBE call.  Other APIs will disallow streaming.

This change makes the `Master::Http::api()` function closely resemble
the `Slave::Http::api()` function.  The main difference is that the
incoming stream reader is stored as a shared_ptr rather than a
Owned object, which to prevent the stream reader from going out of
scope while being passed around via lambda captures.


  src/master/http.cpp 75ab6ea422a77e25049cd6afe007507d11650a06 
  src/master/master.hpp ea7e9242b62fe6c2cc0e717f9a9f2f0c1cc0a390 
  src/master/master.cpp 0c95c438975efd949cbf86f7d8bfea940c20a43a 




See later in chain.


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message