mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 69115: Added test for interactive 'task exec'.
Date Mon, 22 Oct 2018 14:32:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69115/#review209864
-----------------------------------------------------------




src/python/cli_new/lib/cli/tests/task.py
Lines 113 (patched)
<https://reviews.apache.org/r/69115/#comment294467>

    Can we add the same as for the non-interactive case:
    ```
    raise CLIException("Unable to find running task in master state '{master}'".format(master=master))
    ```



src/python/cli_new/lib/cli/tests/task.py
Lines 117-118 (patched)
<https://reviews.apache.org/r/69115/#comment294468>

    Need to change this based on recent constants added for TEST_DIRECTORY and TEST_DATA_DIRECTORY



src/python/cli_new/lib/cli/tests/task.py
Lines 120 (patched)
<https://reviews.apache.org/r/69115/#comment294469>

    This comment seems unnecessary



src/python/cli_new/lib/cli/tests/task.py
Lines 124-126 (patched)
<https://reviews.apache.org/r/69115/#comment294470>

    I don't really like the way we do this. I'd rather just open it twice and get the content
twice.


- Kevin Klues


On Okt. 22, 2018, 11:59 vorm., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69115/
> -----------------------------------------------------------
> 
> (Updated Okt. 22, 2018, 11:59 vorm.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-9342
>     https://issues.apache.org/jira/browse/MESOS-9342
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test for interactive 'task exec'.
> 
> 
> Diffs
> -----
> 
>   src/python/cli_new/lib/cli/tests/task.py b54ade557f579a489e459f6022807146e0211fb0 
> 
> 
> Diff: https://reviews.apache.org/r/69115/diff/1/
> 
> 
> Testing
> -------
> 
> ```
> (mesos-cli) ?  cli_new (MESOS-6551) ? mesos-cli-tests
> Running the Mesos CLI unit tests
> 
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
> 
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
> 
> TestTaskPlugin
> test_exec (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
> test_list (cli.tests.task.TestTaskPlugin) ... ok
> 
> ----------------------------------------------------------------------
> Ran 6 tests in 12.602s
> 
> OK
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message