mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 69114: Added 'exec_command' to test util functions for the new CLI.
Date Mon, 22 Oct 2018 13:28:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69114/#review209851
-----------------------------------------------------------


Ship it!




Ship It!

- Kevin Klues


On Okt. 22, 2018, 1:26 nachm., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69114/
> -----------------------------------------------------------
> 
> (Updated Okt. 22, 2018, 1:26 nachm.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-9341
>     https://issues.apache.org/jira/browse/MESOS-9341
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This code was mostly pulled directly from:
> https://github.com/dcos/dcos-core-cli/blob/
>     7fd55421939a7782c237e2b8719c0fe2f543acd7/
>         python/lib/dcoscli/dcoscli/test/common.py
> 
> This function will be used by tests that do not return a specific output
> but an error code, stdout, and stderr. This will be the case for tests
> concerning the 'task exec' and 'task attach' subcommands.
> 
> 
> Diffs
> -----
> 
>   src/python/cli_new/lib/cli/tests/base.py 3fb471c1f49e930d908322055bb9a188f88ee602 
> 
> 
> Diff: https://reviews.apache.org/r/69114/diff/2/
> 
> 
> Testing
> -------
> 
> Tested later in the chain.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message