mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Review Request 69116: Added 'popen_tty' to test util functions for the new CLI.
Date Mon, 22 Oct 2018 12:23:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69116/
-----------------------------------------------------------

Review request for mesos and Kevin Klues.


Bugs: MESOS-9343
    https://issues.apache.org/jira/browse/MESOS-9343


Repository: mesos


Description
-------

This code was pulled directly from:
https://github.com/dcos/dcos-core-cli/blob/
    7fd55421939a7782c237e2b8719c0fe2f543acd7/
        python/lib/dcoscli/dcoscli/test/common.py

This function will be used by tests requiring a TTY. This will be the
case for tests concerning the 'task attach' subcommand.


Diffs
-----

  src/python/cli_new/lib/cli/tests/base.py 3fb471c1f49e930d908322055bb9a188f88ee602 


Diff: https://reviews.apache.org/r/69116/diff/1/


Testing
-------


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message