mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 69104: Fixed formatting in subcommand help in the new CLI.
Date Sat, 20 Oct 2018 09:37:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69104/
-----------------------------------------------------------

(Updated Okt. 20, 2018, 9:37 vorm.)


Review request for mesos and Armand Grillet.


Changes
-------

Updated testing done


Repository: mesos


Description
-------

Previously, there was some weird formatting with extra newlines when
providing multi-line 'long_help' strings or extra flags to the
subcommands. This commit fixes that.


Diffs
-----

  src/python/cli_new/lib/cli/util.py 6a012369fa151ffd6b73a071342073a55ef9cc6b 


Diff: https://reviews.apache.org/r/69104/diff/1/


Testing (updated)
-------

Old Output:
```
Attach the CLI to the stdio of a running task

Usage:
  mesos task attach (-h | --help)
  mesos task attach --version
  mesos task attach [options] <task-id>

Options:
  --no-stdin  do not attach a stdin [default: False]
  -h --help   Show this screen.


Description:
  
  Attach the CLI to the stdio of a running task
  To detach type the sequence CTRL-p CTRL-q.
```

New output:
```
Attach the CLI to the stdio of a running task

Usage:
  mesos task attach (-h | --help)
  mesos task attach --version
  mesos task attach [options] <task-id>

Options:
  --no-stdin  do not attach a stdin [default: False]
  -h --help   Show this screen.

Description:
  Attach the CLI to the stdio of a running task
  To detach type the sequence CTRL-p CTRL-q.
```


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message