mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 68977: Added Record-IO encoder and decoder to Python library.
Date Tue, 16 Oct 2018 12:35:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68977/
-----------------------------------------------------------

(Updated Okt. 16, 2018, 12:35 nachm.)


Review request for mesos and Kevin Klues.


Changes
-------

Updated test instructions


Bugs: MESOS-6551
    https://issues.apache.org/jira/browse/MESOS-6551


Repository: mesos


Description
-------

Added Record-IO encoder and decoder to Python library.
    
This code was pulled directly from:
https://github.com/dcos/dcos-core-cli/blob/7fd55421939a7782c237e2b8719c0fe2f543acd7/python/lib/dcos/dcos/recordio.py
https://github.com/dcos/dcos-core-cli/blob/7fd55421939a7782c237e2b8719c0fe2f543acd7/python/lib/dcos/tests/test_recordio.py
    
It will be used by the new CLI for commands such as `task exec`.


Diffs
-----

  src/python/lib/mesos/__init__.py 40219c5e03915754b61fc5d7263a063f0d18cca1 
  src/python/lib/mesos/recordio.py PRE-CREATION 
  src/python/lib/tests/test_recordio.py PRE-CREATION 


Diff: https://reviews.apache.org/r/68977/diff/4/


Testing (updated)
-------

```
$ tox -e py3-test -- -vvv -k test_recordio
py3-test installed: atomicwrites==1.2.1,attrs==18.2.0,certifi==2018.10.15,chardet==3.0.4,coverage==4.5.1,idna==2.7,mock==2.0.0,more-itertools==4.3.0,pbr==4.3.0,pluggy==0.8.0,py==1.7.0,pytest==3.7.3,pytest-cov==2.5.1,requests==2.19.1,six==1.11.0,tenacity==4.12.0,ujson==1.35,urllib3==1.23
py3-test runtests: PYTHONHASHSEED='3750347574'
py3-test runtests: commands[0] | py.test -vvv -k test_recordio
==================================================================== test session starts ====================================================================
platform linux -- Python 3.6.2, pytest-3.7.3, py-1.7.0, pluggy-0.8.0 -- /home/mesosphere.com/klueska/mesos/src/python/lib/.tox/py3-test/bin/python3
cachedir: .pytest_cache
rootdir: /home/mesosphere.com/klueska/mesos/src/python/lib, inifile:
plugins: cov-2.5.1
collected 26 items / 24 deselected                                                       
                                                                  

tests/test_recordio.py::test_encode PASSED                                               
                                                            [ 50%]
tests/test_recordio.py::test_encode_decode PASSED                                        
                                                            [100%]

========================================================== 2 passed, 24 deselected in 0.18
seconds ==========================================================
__________________________________________________________________________ summary __________________________________________________________________________
  py3-test: commands succeeded
  congratulations :)
```


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message