mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 68977: Added Record-IO encoder and decoder to Python library.
Date Tue, 16 Oct 2018 12:16:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68977/
-----------------------------------------------------------

(Updated Okt. 16, 2018, 12:16 nachm.)


Review request for mesos and Kevin Klues.


Changes
-------

Changed description


Bugs: MESOS-6551
    https://issues.apache.org/jira/browse/MESOS-6551


Repository: mesos


Description (updated)
-------

Added Record-IO encoder and decoder to Python library.
    
This code was pulled directly from:
https://github.com/dcos/dcos-core-cli/blob/7fd55421939a7782c237e2b8719c0fe2f543acd7/python/lib/dcos/dcos/recordio.py
https://github.com/dcos/dcos-core-cli/blob/7fd55421939a7782c237e2b8719c0fe2f543acd7/python/lib/dcos/tests/test_recordio.py
    
It will be used by the new CLI for commands such as `task exec`.


Diffs
-----

  src/python/lib/mesos/__init__.py 40219c5e03915754b61fc5d7263a063f0d18cca1 
  src/python/lib/mesos/recordio.py PRE-CREATION 
  src/python/lib/tests/test_recordio.py PRE-CREATION 


Diff: https://reviews.apache.org/r/68977/diff/4/


Testing
-------

```
(mesos-cli) ?  python (MESOS-6551) ? mesos-cli-tests
Running the Mesos CLI unit tests

TestAgentPlugin
test_list (cli.tests.agent.TestAgentPlugin) ... ok

TestInfrastructure
test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok

TestRecordIO
test_encode (cli.tests.recordio.TestRecordIO) ... ok
test_encode_decode (cli.tests.recordio.TestRecordIO) ... ok

TestTaskPlugin
test_list (cli.tests.task.TestTaskPlugin) ... ok

----------------------------------------------------------------------
Ran 6 tests in 5.008s

OK
```


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message