mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 68971: Moved import of '../lib' from new CLI bootstrap to pip-requirements.txt.
Date Tue, 16 Oct 2018 11:33:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68971/
-----------------------------------------------------------

(Updated Oct. 16, 2018, 1:33 p.m.)


Review request for mesos and Kevin Klues.


Changes
-------

Rebased.


Bugs: MESOS-6551
    https://issues.apache.org/jira/browse/MESOS-6551


Repository: mesos


Description (updated)
-------

This adds the Mesos Python package to the requirements needed by the
new CLI. We were previously adding the path to the package when setting
up the CLI virtual environment but this does not work with Pylint when
it is run from the linters virtual environment.

By setting things in `pip-requirements.txt`, Pylint does not report
inexisting linting errors when doing imports such as `import mesos`.


Diffs (updated)
-----

  src/python/cli_new/bootstrap a6183d4c28281bf6d29c8b7f825ae474056f027b 
  src/python/cli_new/pip-requirements.txt d1822bf752ce76aa5da5999057fe1efb83747fd0 


Diff: https://reviews.apache.org/r/68971/diff/3/

Changes: https://reviews.apache.org/r/68971/diff/2-3/


Testing
-------

Updated the agent plugin to do `from mesos.exceptions import MesosException` and use `MesosException`.
Commited to see the git hook running and saw the error `E0401: Unable to import 'mesos.exceptions'
(import-error).`. Updated `support/pylint.config`, run the git hook again and saw that the
error was gone.


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message