mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 68995: Removed the child hook `UNSET_CLOEXEC`.
Date Sun, 14 Oct 2018 14:14:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68995/
-----------------------------------------------------------

(Updated Oct. 14, 2018, 10:14 p.m.)


Review request for mesos, Gilbert Song and James Peach.


Bugs: MESOS-9164
    https://issues.apache.org/jira/browse/MESOS-9164


Repository: mesos


Description
-------

We do not need this child hook since any file descripters need
to unset the close-on-exec flag can be put in the `whitelist_fds`
parameter of the `subprocess` method.


Diffs
-----

  3rdparty/libprocess/include/process/subprocess.hpp 135bf243c7e51c88fed6c67804af7f04a2098981

  3rdparty/libprocess/src/subprocess.cpp c0640de2dc4278b884282dfaad98c49c3b067a5b 


Diff: https://reviews.apache.org/r/68995/diff/1/


Testing
-------

sudo make check


Thanks,

Qian Zhang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message