mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Review Request 68993: Introduced `logResponse` for http handlers.
Date Thu, 11 Oct 2018 14:16:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68993/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Benno Evers, Benjamin Mahler, Gastón Kleiman,
and Till Toenshoff.


Repository: mesos


Description
-------

Currently we use `logRequest` function to log requests to endpoints
in Mesos `MasterProcess`, `SlaveProcess`, and `FilesProcess`. Each
request is logged when it is first fetched from the actor mailbox.
However this obviously does not allow for logging the request
processing time.

This patch introduces a `logResponse` function which logs the request
together with the corresponding response status and the time spent
generating the response.


Diffs
-----

  src/common/http.hpp 4f994a0744f098363327b785df56e877c9624e2a 
  src/common/http.cpp 9070071bbb42703b3f62e0cf50b31da943da015c 


Diff: https://reviews.apache.org/r/68993/diff/1/


Testing
-------

See https://reviews.apache.org/r/68994/


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message