mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Review Request 68971: Added pylint init-hook to add Mesos library to `PYTHONPATH`.
Date Wed, 10 Oct 2018 11:11:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68971/
-----------------------------------------------------------

Review request for mesos and Kevin Klues.


Bugs: MESOS-6551
    https://issues.apache.org/jira/browse/MESOS-6551


Repository: mesos


Description
-------

Without this change, adding `from mesos.exceptions import
MesosException` to a file in the new CLI returns `E0401:
Unable to import 'mesos.exceptions' (import-error)`.

This is because the Mesos library is a local module that we need to add
to the `PYTHONPATH`. This is already done when using the virtual
environment of the new CLI and we now also do it when linting.


Diffs
-----

  support/pylint.config af25dd90cb2d467c688ea4b060dc4640040a068b 


Diff: https://reviews.apache.org/r/68971/diff/1/


Testing
-------

Updated the agent plugin to do `from mesos.exceptions import MesosException` and use `MesosException`.
Commited to see the git hook running and saw the error `E0401: Unable to import 'mesos.exceptions'
(import-error).`. Updated `support/pylint.config`, run the git hook again and saw that the
error was gone.


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message