mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 68833: Use total cluster resources as framework sorter "total".
Date Tue, 25 Sep 2018 21:41:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68833/#review209004
-----------------------------------------------------------



If all sorters use the same `total`, then it no longer makes sense to keep multiple copies
of the total in each sorter which is expensive. How about just keeping one `total` in the
allocator, remove `sorter->add/remove` and pass the total to the `sort()`?

- Meng Zhu


On Sept. 24, 2018, 7:23 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68833/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2018, 7:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Meng Zhu.
> 
> 
> Bugs: MESOS-9255
>     https://issues.apache.org/jira/browse/MESOS-9255
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The role sorter and framework sorters differed in that the role
> sorter used the total cluster resources as the "total" in which
> the allocation is divided to compute shares, whereas the framework
> sorters used the role's allocation as the "total".
> 
> Per a discussion on the mailing list:
> 
> https://s.apache.org/differing-DRF
> 
> This patch makes the two types of sorters use the total cluster
> as the "total". While this provides slightly different behavior,
> it's unlikely any users were relying on this.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 906fddc48c52ec222b93d15d53edf9680d2cd861

> 
> 
> Diff: https://reviews.apache.org/r/68833/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message