mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 68816: Prevented leaking files in some stout tests.
Date Sun, 23 Sep 2018 20:39:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68816/#review208932
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['68816']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2387/mesos-review-68816

Relevant logs:

- [stout-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2387/mesos-review-68816/logs/stout-tests-cmake.log):

```
         d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1423): warning C4996:
'setmode': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant
name: _setmode. See online help for details. [D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj]
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
         d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1425): warning C4996:
'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable
deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj]
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
         d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1431): warning C4996:
'fdopen': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant
name: _fdopen. See online help for details. [D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj]
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
         d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\compress.c(205): warning C4244:
'=': conversion from '__int64' to 'Int32', possible loss of data [D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj]
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
         d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(997): warning C4267: '=':
conversion from 'size_t' to 'Int32', possible loss of data [D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj]
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
         d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1056): warning C4267:
'=': conversion from 'size_t' to 'Int32', possible loss of data [D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj]
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
         d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1191): warning C4267:
'=': conversion from 'size_t' to 'Int32', possible loss of data [D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj]
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
         d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1417): warning C4996:
'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable
deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj]
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
         d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1418): warning C4996:
'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable
deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj]
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
         d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1423): warning C4996:
'setmode': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant
name: _setmode. See online help for details. [D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj]
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
         d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1425): warning C4996:
'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable
deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj]
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
         d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1431): warning C4996:
'fdopen': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant
name: _fdopen. See online help for details. [D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj]
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]


       "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\3rdparty\curl-7.61.0.vcxproj" (default target) (6) ->
         LINK : warning LNK4044: unrecognized option '/MANIFEST:NO'; ignored [D:\DCOS\mesos\3rdparty\curl-7.61.0\src\curl-7.61.0-build\lib\libcurl.vcxproj]
[D:\DCOS\mesos\3rdparty\curl-7.61.0.vcxproj]
         LINK : warning LNK4044: unrecognized option '/MANIFEST:NO'; ignored [D:\DCOS\mesos\3rdparty\curl-7.61.0\src\curl-7.61.0-build\lib\libcurl.vcxproj]
[D:\DCOS\mesos\3rdparty\curl-7.61.0.vcxproj]


       "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target) (1) ->
       (ClCompile target) -> 
         d:\dcos\mesos\mesos\3rdparty\stout\tests\main.cpp(68): error C2039: 'rmdir': is not
a member of 'os' [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
         d:\dcos\mesos\mesos\3rdparty\stout\tests\main.cpp(68): error C2664: 'int rmdir(const
char *)': cannot convert argument 1 from 'std::string' to 'const char *' [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]

    141 Warning(s)
    2 Error(s)

Time Elapsed 00:07:57.09
```

- Mesos Reviewbot Windows


On Sept. 23, 2018, 7:32 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68816/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2018, 7:32 p.m.)
> 
> 
> Review request for mesos, Jan Schlicht and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Prevented leaking files in some stout tests.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/tests/main.cpp f08f62f7e9e112f1a4670a504a00b5f9380f9db8 
> 
> 
> Diff: https://reviews.apache.org/r/68816/diff/1/
> 
> 
> Testing
> -------
> 
> Ran `stout-tests` with a custom `TMPDIR` and confirmed that in my setup no more directories
or files are left behind.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message