mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 68803: Fixed flaky test `RemoveExecutorUponFailedLaunch`.
Date Fri, 21 Sep 2018 22:14:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68803/#review208890
-----------------------------------------------------------


Ship it!




Ship It!

- Greg Mann


On Sept. 21, 2018, 9:18 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68803/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2018, 9:18 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The scheduler `statusUpdate` call expectation is not
> necessary and may not get hit in some cases, leading
> to flakiness. Replaced `WillOnce` with `AtMost(1)`.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 9597067799aaedf9d1c9d797454bb4bdf240cde1 
> 
> 
> Diff: https://reviews.apache.org/r/68803/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> run `RemoveExecutorUponFailedLaunch` continuously without failure
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message