mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 68762: Tested container cleanup in `AgentResourceProviderConfigApiTest.Remove`.
Date Thu, 20 Sep 2018 23:15:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68762/
-----------------------------------------------------------

(Updated Sept. 20, 2018, 11:15 p.m.)


Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.


Changes
-------

Fixed the test flakiness.


Summary (updated)
-----------------

Tested container cleanup in `AgentResourceProviderConfigApiTest.Remove`.


Bugs: MESOS-9228
    https://issues.apache.org/jira/browse/MESOS-9228


Repository: mesos


Description
-------

Tested container cleanup in `AgentResourceProviderConfigApiTest.Remove`.


Diffs (updated)
-----

  src/tests/agent_resource_provider_config_api_tests.cpp e6a68bae1a9e3e773ea45deae4951664ab81a857



Diff: https://reviews.apache.org/r/68762/diff/2/

Changes: https://reviews.apache.org/r/68762/diff/1-2/


Testing
-------

make check

The test will fail without the next patch.

NOTE: It might be more appropriate to not reuse this test for container cleanup. Instead,
I'm considering making a similar test in `StorageLocalResourceProviderTest`.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message