mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 68761: Made the actors in resource providers managed by libprocess.
Date Thu, 20 Sep 2018 05:48:46 GMT


> On Sept. 19, 2018, 3:16 p.m., Benjamin Bannier wrote:
> > This seems to be a pretty dramatic change of the API of these classes. Could you
explain when and how users can safely recreate e.g., a `StorageLocalResourceProvider` with
identical config (e.g., identical `workDir`)? There might be a similar issue for the `Driver`,
but there mainly with external effects (e.g., `Driver` not closing connection before a similar
driver reconnects).

The intention is to provide a new `stop` function in the following patches such that one should
always wait for `stop` to complete before creating a new SLRP with an identical config. I
could drop this patch for now if it's too big of a change to backport.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68761/#review208766
-----------------------------------------------------------


On Sept. 19, 2018, 4:53 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68761/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2018, 4:53 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9228
>     https://issues.apache.org/jira/browse/MESOS-9228
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since the local resource provider daemon actively destructs local
> resource providers, we should make the actors managed by libprocess
> and avoid blocking waits during resource provider destructions.
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/resource_provider.hpp 15ede9faf96a981427ed8b3f28b170c893507bc5 
>   src/resource_provider/driver.cpp eda019c1ad8893e14acc5979b350af4a099138be 
>   src/resource_provider/storage/provider.hpp 5a371b19289c6e39fedd4cda65fa8be432d095e6

>   src/resource_provider/storage/provider.cpp 6475f653263337c381b6080695d09c49e5ea8fcf

> 
> 
> Diff: https://reviews.apache.org/r/68761/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message