mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 68769: Fixed rtnl_act leak in routing::filter::internal::attach().
Date Wed, 19 Sep 2018 19:54:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68769/#review208772
-----------------------------------------------------------



PASS: Mesos patch 68769 was successfully built and tested.

Reviews applied: `['68769']`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2358/mesos-review-68769

- Mesos Reviewbot Windows


On Sept. 19, 2018, 8:27 p.m., Ilya Pronin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68769/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2018, 8:27 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We should free the action once we've attached it to a filter, because
> rtnl_basic_add_action() and rtnl_u32_add_action() increase the
> refcounter of rtnl_act object upon adding it to the filter's list.
> 
> Reference grabbing was added to libnl along with a corresponding
> capability NL_CAPABILITY_ROUTE_LINK_CLS_ADD_ACT_OWN_REFERENCE. Its
> support is already checked by Mesos in routing::check(). It seems that
> we simply forgot to adapt our code.
> 
> 
> Diffs
> -----
> 
>   src/linux/routing/filter/internal.hpp 4be4797f84947c46bf3bf629719c13370be5ec1b 
> 
> 
> Diff: https://reviews.apache.org/r/68769/diff/1/
> 
> 
> Testing
> -------
> 
> Tested with Valgrind Memcheck. Ran `sudo make check`.
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message