mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ilya Pronin <ipro...@twopensource.com>
Subject Review Request 68769: Fixed rtnl_act leak in routing::filter::internal::attach().
Date Wed, 19 Sep 2018 18:27:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68769/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Repository: mesos


Description
-------

We should free the action once we've attached it to a filter, because
rtnl_basic_add_action() and rtnl_u32_add_action() increase the
refcounter of rtnl_act object upon adding it to the filter's list.

Reference grabbing was added to libnl along with a corresponding
capability NL_CAPABILITY_ROUTE_LINK_CLS_ADD_ACT_OWN_REFERENCE. Its
support is already checked by Mesos in routing::check(). It seems that
we simply forgot to adapt our code.


Diffs
-----

  src/linux/routing/filter/internal.hpp 4be4797f84947c46bf3bf629719c13370be5ec1b 


Diff: https://reviews.apache.org/r/68769/diff/1/


Testing
-------

Tested with Valgrind Memcheck. Ran `sudo make check`.


Thanks,

Ilya Pronin


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message