mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 68232: Fixed IOSwitchboard waiting EOF from attach container input request.
Date Wed, 29 Aug 2018 10:24:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68232/#review208085
-----------------------------------------------------------




src/slave/containerizer/mesos/io/switchboard.cpp
Lines 1033 (patched)
<https://reviews.apache.org/r/68232/#comment291845>

    I'd suggest to move this to L1037 (righer after `startRedirect`) and still name it `redirectFinished`.



src/slave/containerizer/mesos/io/switchboard.cpp
Lines 1710 (patched)
<https://reviews.apache.org/r/68232/#comment291846>

    Here we set the `promise` in the `readLoop`'s `onAny` callback, but what if `readLoop`
fails? Will the failure be hidden in this case?


- Qian Zhang


On Aug. 25, 2018, 6:12 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68232/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2018, 6:12 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gilbert Song, and Qian
Zhang.
> 
> 
> Bugs: MESOS-9131
>     https://issues.apache.org/jira/browse/MESOS-9131
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, when a corresponding nested container terminated, while the
> user was attached to the container's stdin via `ATTACH_CONTAINER_INPUT`
> IOSwitchboard didn't terminate immediately. IOSwitchboard was waiting
> for EOF message from the input HTTP connection. Since the IOSwitchboard
> was stuck, the corresponding nested container was also stuck in
> `DESTROYING` state.
> 
> This patch fixes the aforementioned issue by sending 200 `OK` response
> for `ATTACH_CONTAINER_INPUT` call in the case when io redirect is
> finished while reading from the HTTP input connection is not.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 52b0e521ed1c651c90b3a3df7c4df576288bf400

> 
> 
> Diff: https://reviews.apache.org/r/68232/diff/2/
> 
> 
> Testing
> -------
> 
> 1. internal CI
> 2. sudo make check (Fedora 25)
> 
> This test fixes `LaunchNestedContainerSessionKillTask` test, which can be found in the
first patch of this patch chain.
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message