mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 68473: Moved members of ReadOnlyHandler into separate file.
Date Mon, 27 Aug 2018 11:18:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68473/#review207963
-----------------------------------------------------------



Nice cleanup, thank! I assume there were no functional changes, just moving around the code.


src/common/http.hpp
Line 165 (original), 165-174 (patched)
<https://reviews.apache.org/r/68473/#comment291634>

    I believe it was meant to be sorted alphabetically. Can you please restore that order
*and* add new lines respectfully?



src/common/http.cpp
Lines 758-766 (patched)
<https://reviews.apache.org/r/68473/#comment291636>

    Can you please sort the definitions to match the _updated_ order of declarations?



src/master/http.cpp
Line 71 (original), 71 (patched)
<https://reviews.apache.org/r/68473/#comment291640>

    Can this be removed now?



src/master/http.cpp
Lines 80 (patched)
<https://reviews.apache.org/r/68473/#comment291641>

    Is it necessary here?



src/master/json.hpp
Lines 17 (patched)
<https://reviews.apache.org/r/68473/#comment291637>

    Why not `__MASTER_JSON_HPP__`?



src/master/json.hpp
Lines 53 (patched)
<https://reviews.apache.org/r/68473/#comment291642>

    => #include \<common/http.hpp>



src/master/json.hpp
Lines 93 (patched)
<https://reviews.apache.org/r/68473/#comment291643>

    => #include \<stout/jsonify.hpp> or fwd decl



src/master/json.cpp
Lines 25 (patched)
<https://reviews.apache.org/r/68473/#comment291644>

    => #include \<string>



src/master/json.cpp
Lines 42 (patched)
<https://reviews.apache.org/r/68473/#comment291645>

    => #include \<stout/jsonify.hpp>



src/master/json.cpp
Lines 162 (patched)
<https://reviews.apache.org/r/68473/#comment291646>

    => #include \<stout/foreach.hpp>



src/master/json.cpp
Lines 240 (patched)
<https://reviews.apache.org/r/68473/#comment291638>

    Remove this line



src/master/json.cpp
Lines 282 (patched)
<https://reviews.apache.org/r/68473/#comment291647>

    => #include \<stout/hashmap.hpp>



src/master/readonly_handler.cpp
Lines 17-23 (patched)
<https://reviews.apache.org/r/68473/#comment291639>

    #include "master/master.hpp"
    
    #include \<mesos/authorizer/authorizer.hpp>
    
    #include "common/build.hpp"
    
    #include "master/json.hpp"



src/master/readonly_handler.cpp
Lines 35 (patched)
<https://reviews.apache.org/r/68473/#comment291648>

    remove this line



src/master/readonly_handler.cpp
Lines 40 (patched)
<https://reviews.apache.org/r/68473/#comment291649>

    remove this line



src/master/readonly_handler.cpp
Lines 91-92 (patched)
<https://reviews.apache.org/r/68473/#comment291650>

    Please have a look at what includes you need to mention in this file.


- Alexander Rukletsov


On Aug. 22, 2018, 1:32 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68473/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2018, 1:32 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved the member functions of class ReadOnlyHandler into
> the new file `readonly_handler.cpp`. This follows the pattern
> established by `weights_handler.cpp` and `quota_handler.cpp`.
> 
> As part of this move, it was also necessary to move some JSON
> serialization that are used from both `master.cpp` and
> `readonly_handler.cpp` to a new pair of files `json.{cpp,hpp}`
> that can be used from both places.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt a80b011bbd5c418ae66eb8dd7697d070168462bb 
>   src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263 
>   src/common/http.hpp 19f0da2004391af7a526026c5e293fb01c01e97c 
>   src/common/http.cpp 932111dde6e49c697bb23e322cae934effacd1b1 
>   src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc 
>   src/master/json.hpp PRE-CREATION 
>   src/master/json.cpp PRE-CREATION 
>   src/master/readonly_handler.cpp PRE-CREATION 
>   src/slave/http.cpp 1b6d266a1a7821c9de6871cbca43317b3c392a32 
> 
> 
> Diff: https://reviews.apache.org/r/68473/diff/2/
> 
> 
> Testing
> -------
> 
> `make`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message