mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Review Request 68232: Fixed IOSwitchboard waiting on EOF from attach container input request.
Date Sat, 25 Aug 2018 10:12:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68232/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gilbert Song, and Qian Zhang.


Summary (updated)
-----------------

Fixed IOSwitchboard waiting on EOF from attach container input request.


Bugs: MESOS-9131
    https://issues.apache.org/jira/browse/MESOS-9131


Repository: mesos


Description (updated)
-------

Previously, when a corresponding nested container terminates, while the
user is attached to the container's stdin via `ATTACH_CONTAINER_INPUT`,
IOSwitchboard didn't terminate immediately. IOSwitchboard was waiting
for EOF message from the input HTTP connection. Since the IOSwitchboard
is stuck, the corresponding nested container is also stuck in
`DESTROYING` state.

This patch fixes the aforementioned issue by sending 200 `OK` response
for `ATTACH_CONTAINER_INPUT` call in the case when io redirect is
finished while reading from the HTTP input connection is not.


Diffs (updated)
-----

  src/slave/containerizer/mesos/io/switchboard.cpp 52b0e521ed1c651c90b3a3df7c4df576288bf400



Diff: https://reviews.apache.org/r/68232/diff/1/


Testing (updated)
-------

1. internal CI
2. sudo make check (Fedora 25)

This test fixes `LaunchNestedContainerSessionKillTask` test, which can be found in the first
patch of this patch chain.


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message