mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 68503: Replaced boost includes with stout equivalents.
Date Fri, 24 Aug 2018 18:39:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68503/#review207910
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/slave.hpp
Line 1048 (original), 1044 (patched)
<https://reviews.apache.org/r/68503/#comment291537>

    Could you also adjust the assignment in `src/slave/slave.cpp:9616`?


- Benjamin Bannier


On Aug. 24, 2018, 5:40 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68503/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2018, 5:40 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced usages of `boost::circular_buffer` with the equivalent
> `circular_buffer` from stout in both master and slave.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp dc0080b24f19b77a4de34ab24aece657726343b8 
>   src/slave/slave.hpp 0420109ac93e1249906c52437e5859c5ee033fb6 
> 
> 
> Diff: https://reviews.apache.org/r/68503/diff/1/
> 
> 
> Testing
> -------
> 
> - Repeated the procedure described in https://reviews.apache.org/r/68484
> - `make check`
> - Internal CI run. (Build #4239)
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message