mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 68502: Added stout wrapper for `boost::circular_buffer`.
Date Fri, 24 Aug 2018 16:50:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68502/#review207893
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/stout/include/stout/circular_buffer.hpp
Lines 13 (patched)
<https://reviews.apache.org/r/68502/#comment291511>

    Currently there are two headers in stout whose names contain underscores: `result_of.hpp`
and `int_fd.hpp`, and both include the underscore in the macro guard. So for consistency,
I suggest using `__STOUT_CIRCULAR_BUFFER_HPP__` instead.



3rdparty/stout/include/stout/circular_buffer.hpp
Lines 16-18 (patched)
<https://reviews.apache.org/r/68502/#comment291510>

    These lines can be removed. See below.



3rdparty/stout/include/stout/circular_buffer.hpp
Lines 23 (patched)
<https://reviews.apache.org/r/68502/#comment291509>

    As suggested in the previous patch, let's add a TODO:
    ```
    // TODO(bevers): Remove this once we bump the minimum Boost version.
    ```



3rdparty/stout/include/stout/circular_buffer.hpp
Lines 27-38 (patched)
<https://reviews.apache.org/r/68502/#comment291508>

    It seems to me that we don't need this. Instead, we could just do the following:
    ```
    using boost::circular_buffer;
    ```


- Chun-Hung Hsiao


On Aug. 24, 2018, 1:48 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68502/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2018, 1:48 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a new file `stout/circular_buffer.hpp` that pulls
> the `boost::circular_buffer` class into the global namespace
> to ensure the boost header is always used with the correct
> macro definitions when included from Mesos.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/Makefile.am 0a4ea7b16b316cc8a411ac9c4d20783530b7168a 
>   3rdparty/stout/include/stout/circular_buffer.hpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68502/diff/1/
> 
> 
> Testing
> -------
> 
> See follow-up review r/68503.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message