mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 68484: Enforced disabling boost debug mode.
Date Fri, 24 Aug 2018 07:55:32 GMT


> On Aug. 23, 2018, 8:08 p.m., Benjamin Mahler wrote:
> > I suppose we need a clear boost minimum version, it's a little surprising that we
let a user run with boost 1.53?
> > 
> > With our other bundled libraries, there are often clear reasons why we bundle specific
versions (e.g. bug fixes), and going below them would be a problem.

I'd go with this patch for now to unblock the 1.7.0 release. Bundled vs. unbundled is an area
where different opinions exist, I'm not sure we can impose a minimum for boost so short before
the 1.7.0 release.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68484/#review207832
-----------------------------------------------------------


On Aug. 23, 2018, 4:25 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68484/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2018, 4:25 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-9177
>     https://issues.apache.org/jira/browse/MESOS-9177
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Always disable boost debug mode.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d 
> 
> 
> Diff: https://reviews.apache.org/r/68484/diff/1/
> 
> 
> Testing
> -------
> 
> * Compiled mesos master against boost 1.53 from https://downloads.mesosphere.com/pkgpanda-artifact-cache/boost_1_53_0.tar.gz.
> * Wrote a script that can trigger a segfault by reading from a circular buffer in parallel
(pasted in the linked ticket) and verified that it crashes mesos master.
> * Recompiled mesos with this patch applied.
> * Verified that the above script does not produce a segfault anymore.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message