mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 68348: Fixed wrong `mnt` namespace detection for non-command executor tasks.
Date Fri, 17 Aug 2018 21:21:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68348/#review207552
-----------------------------------------------------------


Fix it, then Ship it!




Maybe mention in "testing done" the newly added `ROOT_CGROUPS_LaunchNestedDebugAfterUnshareMntNamespace`
test?


src/slave/containerizer/mesos/containerizer.cpp
Line 1943 (original), 1943 (patched)
<https://reviews.apache.org/r/68348/#comment290942>

    s/container/parentContainer



src/slave/containerizer/mesos/containerizer.cpp
Lines 1952 (patched)
<https://reviews.apache.org/r/68348/#comment290943>

    s/enter task's/enter the task's


- Alexander Rukletsov


On Aug. 14, 2018, 5:26 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68348/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2018, 5:26 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, Jie Yu, and Kevin Klues.
> 
> 
> Bugs: MESOS-9116
>     https://issues.apache.org/jira/browse/MESOS-9116
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, we were calling `getMountNamespaceTarget()` not only in
> case of the command executor but in all other cases too, including
> the default executor. That might lead to various subtle bugs, caused by
> wrong detection of `mnt` namespace target. This patch fixes the issue
> by setting a parent PID as `mnt` namespace target in case of
> non-command executor task.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 98129d006cda9b65804b518619b6addc8990410a

> 
> 
> Diff: https://reviews.apache.org/r/68348/diff/2/
> 
> 
> Testing
> -------
> 
> 1. sudo make check (Fedora 25)
> 2. internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message