mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 68408: Added `ROOT_CGROUPS_LaunchNestedDebugAfterUnshareMntNamespace` test.
Date Fri, 17 Aug 2018 21:14:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68408/#review207550
-----------------------------------------------------------


Ship it!




Do I understand correctly, that this test fails without the subsequent https://reviews.apache.org/r/68348
patch? If so, can you please update the "testing done" section saying so?

- Alexander Rukletsov


On Aug. 17, 2018, 12:17 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68408/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2018, 12:17 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, Jie Yu, and Kevin Klues.
> 
> 
> Bugs: MESOS-9116
>     https://issues.apache.org/jira/browse/MESOS-9116
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test verifies detection of task's `mnt` namespace for a debug
> nested container. Debug nested container must enter `mnt` namespace
> of the task, so the agent tries to detect task's `mnt` namespace.
> This test launches a long-running task which runs a subtask that
> unshares `mnt` namespace. The structure of the resulting process tree
> is similar to the process tree of the command executor (the task of
> the command executor unshares `mnt` ns):
> 
>   0. root (aka "nanny"/"launcher" process) [root `mnt` namespace]
>     1. task: sleep 1000 [root `mnt` namespace]
>       2. subtaks: sleep 1000 [subtask's `mnt` namespace]
> 
> We expect that the agent detects task's `mnt` namespace.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp b80e40b6f4b18e076ebb3c1668f475286c337127

> 
> 
> Diff: https://reviews.apache.org/r/68408/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message