mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 68145: Sent an event to resource providers when they are removed.
Date Thu, 16 Aug 2018 23:45:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68145/#review207452
-----------------------------------------------------------



Seems that we need to update SLRP as well?


include/mesos/resource_provider/resource_provider.proto
Lines 102 (patched)
<https://reviews.apache.org/r/68145/#comment290854>

    `... when the resource provider is requested to be torn down.`



include/mesos/resource_provider/resource_provider.proto
Lines 103 (patched)
<https://reviews.apache.org/r/68145/#comment290855>

    Do we actually need this message at all?



include/mesos/v1/resource_provider/resource_provider.proto
Lines 102-103 (patched)
<https://reviews.apache.org/r/68145/#comment290856>

    Ditto.



src/resource_provider/manager.cpp
Lines 635-637 (patched)
<https://reviews.apache.org/r/68145/#comment290859>

    Move this into the then-branch?



src/resource_provider/manager.cpp
Lines 645 (patched)
<https://reviews.apache.org/r/68145/#comment290857>

    s/`REMOVED`/`TEARDOWN`/



src/resource_provider/manager.cpp
Lines 650 (patched)
<https://reviews.apache.org/r/68145/#comment290858>

    s/`REMOVED`/`TEARDOWN`/


- Chun-Hung Hsiao


On Aug. 16, 2018, 2:30 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68145/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2018, 2:30 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-8403
>     https://issues.apache.org/jira/browse/MESOS-8403
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In order to allow proper cleanup the resource provider manager sends a
> `REMOVED` to a resource provider when it is being removed.
> 
> The event is not sent reliably, i.e., if the resource provider was
> e.g., not subscribed when it was removed we currently will never
> attempt to resend the event.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resource_provider/resource_provider.proto 7c6833378401751a8997ecd3279cf3bf2ad3cbf4

>   include/mesos/v1/resource_provider/resource_provider.proto 535b898b03cd3d81261d62523916cf9a6410a30d

>   src/resource_provider/manager.cpp abd7e38e5517ea600f9fc9b8a96c7d0d26df0620 
>   src/resource_provider/storage/provider.cpp 22c184f45ea43335c3e1e4598f7409a4f05fb38e

>   src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8 
> 
> 
> Diff: https://reviews.apache.org/r/68145/diff/5/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> Additional testing with the test case added in https://reviews.apache.org/r/68147/.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message